Fix null-ref in AliasSymbol.Equals
#59649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
reviewed
Feb 18, 2022
| @@ -253,7 +254,7 @@ public override bool Equals(Symbol? obj, TypeCompareKind compareKind) | |||
|
|
|||
| return (object?)other != null && | |||
| Equals(this.Locations.FirstOrDefault(), other.Locations.FirstOrDefault()) && | |||
| this.ContainingAssembly.Equals(other.ContainingAssembly, compareKind); | |||
| Equals(this.ContainingSymbol, other.ContainingSymbol, compareKind); | |||
There was a problem hiding this comment.
Yes, I think we want the symbols not to be equal in the scenario with two compilations. But if we use ContainingAssembly (which is null) then they would be equal.
If we use ContainingSymbol (which is the global namespace) then they are not equal, which I think is correct.
We could only compare using ContainingSymbol when ContainingAssembly is null, if that seems better.
There was a problem hiding this comment.
Isn't this a change in behavior then?
There was a problem hiding this comment.
Previous behavior for that scenario was a crash (null-ref). I don't think there's a change of behavior aside from that.
Am I missing something?
|
@dotnet/roslyn-compiler for second review. Thanks |
cston
approved these changes
Feb 19, 2022
jcouv
changed the title
AliasSymbol.Equals
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58999
FYI @AlekseyTs